examples: fix README drift and remove incomplete retool example - #182
Closed
aoshen02 wants to merge 1 commit into
Closed
examples: fix README drift and remove incomplete retool example#182aoshen02 wants to merge 1 commit into
aoshen02 wants to merge 1 commit into
Conversation
The examples/README directory listing had drifted from the actual contents: - Removed dead links to `eval_multi_task` and `reproducibility` — neither directory exists under examples/ (reproducibility is a docs/ page, not an example). - Added the existing `coding_agent_rl` example, which was present on disk but unlisted. - Removed `examples/retool/`: it was an incomplete stub (only generate_with_retool.py + tool_sandbox.py, no README and no run scripts), unreferenced anywhere else in the repo, and was likewise unlisted in the README. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the examples directory by removing the retool and tool sandbox modules, as well as updating the README to document the new coding_agent_rl example and remove references to eval_multi_task and reproducibility. There are no review comments, so I have no feedback to provide.
Collaborator
Author
|
Folded into #180 to keep all content-trim docs/examples changes in a single PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Continuing the docs/examples consistency pass.
examples/README.mdhad drifted from the actualexamples/contents in both directions, and one example directory was an incomplete stub.Changes
examples/README.mdeval_multi_task— no such directory underexamples/.reproducibility— it's adocs/page, not an example directory.coding_agent_rl— a complete example (README +generate.py+ shared adapter) that existed on disk but was unlisted.Removed
examples/retool/generate_with_retool.py+tool_sandbox.py, with no README and no run scripts (unlike upstream slime's fullretool/). It was unlisted in the README and not referenced anywhere else in the repo (verified via grep).Verification
examples/README.mdexists, and every example directory on disk is listed.grep -rin retoolacross*.py/*.sh/*.md/*.yml/*.j2(excluding the deleted dir) returns no external references.Out of scope (inherited from slime — flagged, not touched here)
These are identical in upstream slime and fixing them in vime alone would diverge from the mirror:
examples/DrGRPO/custom_reducer.pyis cited incustomization.mdandvime/utils/arguments.py(asDr.GRPO, with a spelling mismatch) but exists in neither vime nor slime.examples/geo3k_vlm/README.mdhas a broken self-link./examples/geo_3k_vlm/run_geo3k_vlm_sft.sh(typo), same as slime.